Rewrite Rules: Fix rewrite rules breaking for taxonomies with URL-encoded Unicode slugs - #12863
Draft
SainathPoojary wants to merge 2 commits into
Draft
Rewrite Rules: Fix rewrite rules breaking for taxonomies with URL-encoded Unicode slugs#12863SainathPoojary wants to merge 2 commits into
SainathPoojary wants to merge 2 commits into
Conversation
…ture group misalignment
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intercepts the permastruct inside
WP_Rewrite::add_permastruct()and decodes the URL-encoded slug back into standard UTF-8 text before saving it.To ensure we don't accidentally corrupt real rewrite tags (where
%cain%category%could be decoded by a naiveurldecode), we use apreg_replace_callbackthat strictly decodes only uppercase hex strings ([0-9A-F]). WordPress's URL encoding always uses uppercase, while built-in rewrite tags use lowercase, making this a safe and robust fix.Trac ticket: #41791
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.